-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove builds.json API endpoint #2198
base: master
Are you sure you want to change the base?
Conversation
We did quite a few times, but it was years ago when it wasn't already part of |
I have future changes that would require breaking this endpoint, or making what it says about the crate not really match what we're storing about it. |
I'm not sure if it is really a public API, I don't believe there's any documentation about it, we've just used it for integrations we at least partially manage like crates.io or shields.io. |
https://aws.amazon.com/blogs/networking-and-content-delivery/amazon-cloudfront-announces-cache-and-origin-request-policies/ seems like it should support us forwarding the user-agent to the service, I'll see if I can figure out how this looks in terraform and open a PR. |
We've had 20 requests so far since simpleinfra#344 was deployed, they appear to be a variety of desktop/mobile browser user-agents, so my best guess is there is some website/browser plugin that is doing the request client-side. user agents
|
I tried a github code search too, and didn't find anything relevant, just a bunch of docs.rs, crates.io and shields forks. |
I had a chat with Tobias (crates.io) who in the end have a similar issue (private APIs that are publicly used). To get more info I created rust-lang/simpleinfra#354 to be able to look into the but currently I lean towards keeping the API alive it's not too much effort. From what I remember it would need generating the |
This is blocked on
|
I would have exact stats, but grafana is currently down 🙃. IIRC we went from ~100 req/min to somewhere around 1 req/hour. The major consumers crates.io and shields.io have definitely migrated, lib.rs is the other known consumer and @kornelski 👍'd my comment about migrating so I hope it has updated by now.